DM-48801: Enable Sentry error logging for TAP service and transactions for Query Runner #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stvoutsin
force-pushed
the
tickets/DM-48801
branch
3 times, most recently
from
e90838f to
863e353
Compare
stvoutsin
force-pushed
the
tickets/DM-48801
branch
from
9e26646 to
309e98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to bring Sentry into the CADC TAP service (Qserv-based one). Specifically this allows errors to propagate into Sentry Issues, and also adds tracing for queries via the
QServQueryRunner.The new features are optional and only enabled if the
SENTRY_DSNenvironment variable is set, which then depends on it being enabled in phalanx for the environment for which we with to enable it.When building locally, if we want the stack trace to include detailed context with code where the error occurred included we need to enable SENTRY_AUTH_TOKEN to a token we get from SENTRY.
Jira Issue
https://rubinobs.atlassian.net/browse/DM-48801
Tests
I've tested on an env with SENTRY_DSN enabled, and then the same build with SENTRY_DSN disabled in phalanx to ensure that tracing doesn't get sent in the second case