Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent footer from being partially hidden on Firefox #1346

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Prevent footer from being partially hidden on Firefox #1346

merged 1 commit into from
Aug 7, 2020

Conversation

benoittgt
Copy link
Contributor

Description

I noticed that the footer is partially hidden in Firefox but not in Chrome. This patch make the footer fully visible.

Jul-28-2020 14-41-14

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.439% when pulling 3b03435 on benoittgt:firefox-footer-unshrinked into d7a16c5 on lsegal:main.

@benoittgt benoittgt mentioned this pull request Jul 28, 2020
Merged
@lsegal lsegal merged commit 0e7e9ec into lsegal:main Aug 7, 2020
@lsegal
Copy link
Owner

lsegal commented Aug 7, 2020

Thanks for the quick fix!

@benoittgt benoittgt deleted the firefox-footer-unshrinked branch August 8, 2020 07:32
lsegal added a commit that referenced this pull request Dec 27, 2020
@lsegal
Tag release v0.9.26
d202e9d 
References:
  #1328, #1331, #1339, #1343, #1344, #1345, #1346, #1347,
  #1363, #1364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoittgt @coveralls @lsegal