Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline
: Ingestion pipeline #96Pipeline
: Ingestion pipeline #96Changes from 180 commits
403f118
e7c74f2
26e86ac
6997315
128ea40
0818109
70ed83f
7acf809
2c0793a
b4cb05d
2f3882f
05490f2
e08aac6
a29a44b
0c96395
e9874b9
3a186c9
379550b
0f6e576
a4186c3
9f2848e
224a701
93a2f44
bca6377
6e9525d
bc97236
b0291b1
7211386
738e7a0
303f6d4
1dfd03a
f3b3c93
34bc567
67d6bd0
2fe64ab
4ef1672
d15c6e6
0f57336
bcc54c2
22a96ab
981a453
a0b1676
1b372ec
7c48731
5c94f8d
5261e94
67226d2
deaebf0
ea7291c
0cbc8ca
fa4e705
53edf86
57b0d72
f567809
f8aef7e
7a6270b
bc69e96
bea9fcf
12b33f9
d46f7e7
b4acb1d
412d5a7
2ac1d48
58ac585
892bd6f
e05206c
1ca6b8e
c72f8ad
5d29c93
2e09692
fe76c80
ec964c3
f961717
1171b25
ab73df5
c7518ee
1bd1b85
764931e
6c60225
a9c77c1
69c791a
c7f53ee
aa247b8
4dd3b3d
f06e884
008a9e5
b4d0120
42ce267
fcbddc5
4bd9cd2
7021ba5
bc75592
0ac2712
b50ea25
dfa3063
eb5f446
586aa1e
5133adc
5abd811
3e77483
1da1d5e
4699fed
ea32c7b
6bc383a
19e2c6c
b0e6f1d
f56c288
2e25f9d
db9d67a
dfdb5e5
719aec2
27c91d7
9a50a79
d9dd8bc
9a1679d
53b13d8
1b477ff
dca1493
fd11add
3930890
5a70b5c
ef1b4ef
c9587c5
7b40f7c
8e3d710
a8a3c4f
b410cf3
32f33be
6062f39
67c3ee6
d1e9874
0eadd32
d37851a
f4c8c3c
46e157a
b89703e
730305f
0f354ae
190587c
4751070
dd9fed4
dbaef87
e620fcb
f5f1738
d9c458e
ed7b2e1
dd21a1a
ca35123
50bd537
abdbc21
7728d03
753cdbb
7a80e5f
f854fd4
6192932
8b1345f
ed51977
ccbffbb
b89a58f
5f6b8b7
b0df9f2
58258c9
092a0ec
d22c856
ca11b9e
16e0e49
930050d
d503ba2
e4c7575
a6b70ac
e5b34f0
c60921b
9e34fc2
28d99cf
4843299
dc205ed
847913d
692a10a
d5d926e
5732e7c
cba0561
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider specifying exception types to improve error diagnostics and handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper thread management and exception handling in threading logic.
The threading logic within the
__call__
method does not appear to handle exceptions or race conditions effectively. Consider implementing thread joining or using a thread pool to manage threads more safely. Additionally, ensure that shared resources are accessed in a thread-safe manner. Here is a proposed change:Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimize the method
should_execute_lecture_pipeline
.The method
should_execute_lecture_pipeline
can be optimized by directly returning the condition in theif
statement. This change makes the function more concise and easier to read, as previously suggested:Committable suggestion