Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Warnings in the assessment editor trigger flickering #8731

Closed
BaumiCoder opened this issue Jun 4, 2024 · 3 comments
Closed
Assignees

Comments

@BaumiCoder
Copy link
Contributor

BaumiCoder commented Jun 4, 2024

Describe the bug

If there are warnings in the assessment editor from static code analyses (e.g. Checkstyle), you get some kind of flickering. It occurs when you move your mouse of the code lines, and you hit some lines with warnings.

One possible solution could be to make the column weight enough to contain both icons, if there are warnings in at least one line, independent of the actual line of the mouse course.

To Reproduce

  1. Create a programming exercise with static code analysis (e.g. Java Maven Project)
  2. Make a submission for this exercise with changes that add warning (e.g. Rename the constants in the Client.java see Screenshots)
  3. Set the Due Date of the exercise to now and add a manual assessment
  4. Open your submission in the assessment editor
  5. Went through the code with your mouse courser

Expected behavior

There are no visual distractions when going through the code with the mouse courser.

Screenshots

example
Gif convertation had added some color bugs, so here also the video file: https://github.com/ls1intum/Artemis/assets/73783062/63fe0676-5d80-4184-8b29-0f1c79d540f9

Which version of Artemis are you seeing the problem on?

7.1.2

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response

@pzdr7
Copy link
Contributor

pzdr7 commented Jun 5, 2024

This was the workaround we implemented to prevent the button being hidden under the build annotations. We might be able to move the button to the right of the line numbers.

I quickly typed something up in the Monaco Editor playground: example - move your mouse around in the preview editor

Would you prefer it if this was what it looked like?

@pzdr7 pzdr7 self-assigned this Jun 5, 2024
@BaumiCoder
Copy link
Contributor Author

Yes, that approach seems suitable for me if nobody misses the arrows to collapse code blocks like methods.

When changing already something here, a more discreet icon would be nice e.g., a lighter color. If you read the code with your mouse cursor as a pointer, you can be easily got distracted from the moving icon on the left.

@pzdr7
Copy link
Contributor

pzdr7 commented Jul 5, 2024

Resolved in #8921

@pzdr7 pzdr7 closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants