Do not ignore cases for attribute names #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesStoehr
added
enhancement
MaisiKoleni
reviewed
Dec 11, 2022
MaisiKoleni
approved these changes
Dec 11, 2022
MaisiKoleni
removed
the
structural-tests
|
Thank you! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ares did ignore the cases of attributes so far, which lead to some problems when other tests relied on the exact case or the student had different attributes with the same name but different cases (i.e. id and static ID to count up all created ids).
This PR removes this behavior, so attributes are now case sensitive