Skip to content

Commit

Permalink
feat(diff): Add a todo based on PR feedback and update of the CHANGEL…
Browse files Browse the repository at this point in the history
…OG.md
  • Loading branch information
lquerel committed Jan 30, 2025
1 parent a6db5d8 commit 914409e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ All notable changes to this project will be documented in this file.

What's changed

* Added a new `weaver registry diff` command to generate a diff report between two versions of the semantic convention
registry. ([#400](https://github.com/open-telemetry/weaver/pull/400/) by @lquerel).
* For issue [#569](Add include_stability config into semconv_grouped_attributes): `is_experimental` returns `true` by default. ([#570](https://github.com/open-telemetry/weaver/pull/570) by @jerbly).
* Added an OTLP receiver to Weaver to prepare for the `weaver registry live-check` command. (see [#548](https://github.com/open-telemetry/weaver/pull/548) by @lquerel)
* Refactored CLI registry commands to remove some duplication. Resolving the registry with policy checks is common for `generate`, `resolve` and `check`. ([#536](https://github.com/open-telemetry/weaver/pull/536) by @jerbly).
Expand Down
1 change: 1 addition & 0 deletions crates/weaver_semconv/src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ impl SemConvRegistry {
registry_repo: &RegistryRepo,
semconv_specs: Vec<(String, SemConvSpec)>,
) -> Result<SemConvRegistry, Error> {
// ToDo We should use: https://docs.rs/semver/latest/semver/ and URL parser that can give us the last element of the path to send to the parser.
static VERSION_REGEX: LazyLock<Regex> =
LazyLock::new(|| Regex::new(r".*(v\d+\.\d+\.\d+).*").expect("Invalid regex"));

Expand Down

0 comments on commit 914409e

Please sign in to comment.