Fix wrong parsing of arrays with text "NULL" #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array parser fails to detect the proper escaping of an
textual element 'NULL' and interpret it as a null value throwing
UnexpectedNull to a perfect valid not nullable array (i.e. "SELECT '{sometext, \"NULL\"}'::_text" ~ PGArray Text).
|
Thanks! I'll try to get this released soon, but I'd like to take a quick swipe at #186. |
lostbean
added a commit
to silkapp/haskell-opaleye
that referenced
this pull request
Jun 13, 2016
This also removes a bug that was that was in both codes. See lpsmith/postgresql-simple#189
lostbean
added a commit
to silkapp/haskell-opaleye
that referenced
this pull request
Jun 14, 2016
This commit avoids the code to get out of sync with postgresql-simple (i.e. lpsmith/postgresql-simple#189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was affecting arrays that contained the text "NULL". The parser failed to recognise the correct escaping of the text "NULL" and interpreted it as a null value, throwing the following error:
This PR also adds a new test case for the test suite.