Relax dependency on time crate, and other issues with Rust 1.78+ (fixes #76) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constraint pins a version of time that gets broken by at least with Rust 1.78 and later. 8897b33 does not explain why it was introduced, maybe because of a subsequent release. Just removing the pin will add the fewer constraints and thus break less various settings.
time-rs was not alone to fail building with more recent toolchains.
ydirson
force-pushed
the
leptonic-0.5
branch
from
14e408d to
b36b531
Compare
ydirson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a single commit on top of v0.5.0, with the aim of unblocking users with a v0.5.1 until work resumes on
main. It would belong to aleptonic-0.5branch of sorts for producing 0.5.x maintenance releases.It allows getting fixed and uptodate versions of
timeandleptos-use, and deals with warnings cluttering build log.