Trying vcr

[trevordocherty]

Resolves #1

Description

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Documentation update

How Has This Been Tested?

Screenshots

[nihonjinrxs]

@trevordocherty the failures here are code style failures. To see those locally, you can run

bundle exec rubocop

Here are the failures showing in the CI build log (which you can see by clicking on one of the Details links for the CI builds below or by clicking on the red X next to the commit ID above):

Offenses:
spec/vcr_setup.rb:1:9: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
require 'vcr'
        ^^^^^
spec/vcr_setup.rb:4:28: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
  c.cassette_library_dir = 'spec/vcr_cassettes'
                           ^^^^^^^^^^^^^^^^^^^^
spec/vcr_setup.rb:8:1: C: Layout/EmptyLines: Extra blank line detected.
spec/vcr_setup.rb:12:34: C: Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
  c.default_cassette_options = { :record => record_mode }
                                 ^^^^^^^^^^
66 files inspected, 4 offenses detected

3 of 4 should be self-explanatory. The last one is asking you to use the { key: value } syntax form of a hash, rather than { :key => value }.

[nihonjinrxs]

@trevordocherty You've got a merge conflict now. This is likely because I pulled upstream's master branch a bit earlier this evening and things have been updated there.

[nihonjinrxs]

@trevordocherty that commit modified the Gemfile.lock but didn't actually resolve the merge conflict.

You can look at the merge conflict in Github via the "Resolve conflicts" button. May be worthwhile to do that so you can see exactly what the conflict is.

Also, conflicts are identified like changes in a diff are, set apart by <<<<< and >>>>>. Searching the file for those character strings can help also.

[mdworken]

Can you un-delete the Gemfile.lock? Looks good besides that I think

[trevordocherty]

@mdworken added the file back

[nihonjinrxs]

@mdworken when you get a chance, can you please review this one?

[nihonjinrxs]

@trevordocherty you'll need to re-merge master into this branch, as it's out of date.

[mdworken]

Looks like the Gemfile.lock is showing as all deleted then re-added in git. If you'd like I can help you fix this.

[trevordocherty]

I fixed it

[trevordocherty]

@mdworken can you look at this again?