Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds styles for figure and figcaption. #17

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Conversation

xge
Copy link
Contributor

@xge xge commented Apr 11, 2024

I realized concrete is missing styles for <figure> and <figcaption>, so I added these. Figure contains a full-width image, a right-aligned figure caption in smaller text and a properly spaced bottom border. The bottom border is copied from <blockquote>'s left border.

I tried to mimic concrete's design and code style. Please feel free to change as you see fit.

Preview images:

figure and figcaption in dark mode
figure-dark

figure and figcaption in light mode
figure-light

Further resources:

figure in MDN

@louismerlin
Copy link
Owner

Very cool, thank you very much!

I’ll take a closer look later today or tomorrow, but this looks very polished already ✨

@louismerlin
Copy link
Owner

@xge what do you think about moving the border-bottom and padding-bottom rules from caption to figcaption?

This makes it such that a figure without a figcaptiondoes not have a black line under it.

@xge
Copy link
Contributor Author

xge commented Apr 11, 2024

Yeah, I'm fine with that. I'll update the PR.
Edit: @louismerlin you mean moving from figure to figcaption, right? I cannot find any styles for caption.
Edit 2: made the changes, updated the PR.

@louismerlin
Copy link
Owner

Edit: @louismerlin you mean moving from figure to figcaption, right? I cannot find any styles for caption.

Yes sorry for the confusion 😄

@louismerlin
Copy link
Owner

I adjusted the padding of the figcaption, everything looks very nice!

Danke schön @xge for the contribution 🙌

@louismerlin
Copy link
Owner

I'll merge #13 and #16 along with this PR tomorrow and publish v3.0.0 😄

@louismerlin louismerlin merged commit ea437f7 into louismerlin:main Apr 12, 2024
@xge xge deleted the figure branch April 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants