Custom id generator #212
Open
Custom id generator #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the idea. I'll review it when I have time unfortunately probably not now. Also, note that in nedb browser version there is an id generator that doesn't use crypto, so maybe using it on an embedded device could be a good option. The minified version could be pretty well suited. |
JamesMGreene
added a commit
to JamesMGreene/nestdb
that referenced
this pull request
Sep 5, 2017
Also modified the ID generation integrity check to work via an iterative loop rather than via recursion Fixes #10 Closes louischatriot/nedb#212
|
This feature would help electron users which make use of NeDB to workaround electron/electron#2073. The problem is that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option for a custom id generator function.
I use nedb on an embedded Device. On this device the
cryptomodule doesn't contain therandomBytesfunction which is used by nedb for generating ids.