[REFACTOR] 리팩터링 DTO

lotteon2 · Dec 1, 2023 · 5e6ee7b · 5e6ee7b
1 parent f953d93
commit 5e6ee7b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 20 deletions.
diff --git a/src/main/java/com/dailyon/snsservice/dto/response/follow/FollowerPageResponse.java b/src/main/java/com/dailyon/snsservice/dto/response/follow/FollowerPageResponse.java
@@ -1,8 +1,7 @@
 package com.dailyon.snsservice.dto.response.follow;
 
-import com.dailyon.snsservice.entity.Member;
 import java.util.List;
-import java.util.stream.Collectors;
+
 import lombok.*;
 import org.springframework.data.domain.Page;
 
@@ -16,19 +15,11 @@ public class FollowerPageResponse {
   private long totalElements;
   private List<FollowerResponse> followers;
 
-  public static FollowerPageResponse fromEntity(Page<Member> followers) {
+  public static FollowerPageResponse fromDto(Page<FollowerResponse> followerResponses) {
     return FollowerPageResponse.builder()
-        .totalPages(followers.getTotalPages())
-        .totalElements(followers.getTotalElements())
-        .followers(followers.getContent().stream()
-                .map(
-                        follower ->
-                                FollowerResponse.builder()
-                                        .id(follower.getId())
-                                        .nickname(follower.getNickname())
-                                        .profileImgUrl(follower.getProfileImgUrl())
-                                        .build())
-                .collect(Collectors.toList()))
-        .build();
+            .totalPages(followerResponses.getTotalPages())
+            .totalElements(followerResponses.getTotalElements())
+            .followers(followerResponses.getContent())
+            .build();
   }
 }
diff --git a/src/main/java/com/dailyon/snsservice/service/follow/FollowService.java b/src/main/java/com/dailyon/snsservice/service/follow/FollowService.java
@@ -31,10 +31,6 @@ public FollowingPageResponse getFollowings(Long memberId, Pageable pageable) {
   public FollowerPageResponse getFollowers(Long memberId, Pageable pageable) {
     Page<FollowerResponse> followerResponses =
             followRepository.findFollowersByMemberId(memberId, pageable);
-    return FollowerPageResponse.builder()
-            .totalPages(followerResponses.getTotalPages())
-            .totalElements(followerResponses.getTotalElements())
-            .followers(followerResponses.getContent())
-            .build();
+    return FollowerPageResponse.fromDto(followerResponses);
   }
 }