Add new error classes #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-class (e.g. `ClientError`) was previously accessible either through the `Faraday` module (e.g. `Faraday::ClientError`) or through the `Faraday::Error` class (e.g. `Faraday::Error::ClientError`). The latter is no longer available and the former should be used instead, so check your `rescue`s. * Introduces a new `Faraday::ServerError` (5xx status codes) alongside the existing `Faraday::ClientError` (4xx status codes). Please note `Faraday::ClientError` was previously used for both. * Introduces new Errors that describe the most common REST status codes: * Faraday::BadRequestError (400) * Faraday::UnauthorizedError (401) * Faraday::ForbiddenError (403) * Faraday::ProxyAuthError (407). Please note this raised a `Faraday::ConnectionFailed` before. * Faraday::UnprocessableEntityError (422)
|
@olleolleolle you're welcome to have a review 👍 ! |
iMacTia
added a commit
to iMacTia/typhoeus
that referenced
this pull request
Jan 4, 2019
As of lostisland/faraday#841, we've changed the exceptions namespace. This change needs to be reflected on exceptions raised by this adapter. This change is required in order to support Faraday 1.0, and should be fully backwards-compatible with older versions of Faraday.
olleolleolle
approved these changes
Jan 4, 2019
| @@ -1,5 +1,6 @@ | |||
| RSpec.describe Faraday::Adapter::Typhoeus do | |||
| features :body_on_get, :parallel | |||
|
|
|||
| it_behaves_like 'an adapter' | |||
| # Commenting until Typhoeus is updated to support v1.0 | |||
| # it_behaves_like 'an adapter' | |||
| expect { conn.get('ok') }.not_to raise_error | ||
| end | ||
|
|
||
| it 'raise Faraday::Error::ResourceNotFound for 404 responses' do | ||
| expect { conn.get('not-found') }.to raise_error(Faraday::Error::ResourceNotFound) do |ex| | ||
| it 'raise Faraday::ResourceNotFound for 400 responses' do |
There was a problem hiding this comment.
The description could use the “raises” tense of that verb (throughout these cases). It was the wrong form before your changes, too.
|
@olleolleolle Thanks for pointing out both! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Faraday::Error. A sub-class (e.g.ClientError) was previously accessible either through theFaradaymodule (e.g.Faraday::ClientError) or through theFaraday::Errorclass (e.g.Faraday::Error::ClientError).The latter is no longer available and the former should be used instead, so check your
rescues.Faraday::ServerError(5xx status codes) alongside the existingFaraday::ClientError(4xx status codes).Please note
Faraday::ClientErrorwas previously used for both.Faraday::ConnectionFailedbefore.Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Replaces #735