style all scopes (v2) #2
Conversation
| ~type, ~package, ~task, ~learner, ~prediction, ~measure, | ||
| "regr", "mlr3", "TaskRegr", "LearnerRegr", "PredictionRegr", "MeasureRegr", | ||
| "classif", "mlr3", "TaskClassif", "LearnerClassif", "PredictionClassif", "MeasureClassif" | ||
| ~type, ~package, ~task, ~learner, ~prediction, ~measure, | ||
| "regr", "mlr3", "TaskRegr", "LearnerRegr", "PredictionRegr", "MeasureRegr", | ||
| "classif", "mlr3", "TaskClassif", "LearnerClassif", "PredictionClassif", "MeasureClassif" |
| y = factor(rep(c("A", "B"), c(n1, n2)), levels = c("A", "B")), | ||
| x1 = 5 * cos(x) + rnorm(n, mean = mu, sd = sigma), | ||
| x2 = 10 * sin(x) + rnorm(n, mean = mu, sd = sigma) |
There was a problem hiding this comment.
@lorenzwalthert This indentation looks off - is this causes because l61/62 start with numbers?
There was a problem hiding this comment.
indention or spacing after the first =? It was aligned before and styler does not allow complicated left alignment, so I made it right-aligned. We can also unalign if you want.
There was a problem hiding this comment.
Ah now I see - cos and sin were aligned before but complicated left alignment is not possible.
I think right alignment here is somehow non-standard - I think I'd prefer non-matching left alignment after =.
x1 = 5 * cos(x) + rnorm(n, mean = mu, sd = sigma),
x2 = 10 * sin(x) + rnorm(n, mean = mu, sd = sigma)
|
@pat-s let me know when you want this PR to go to the upstream mlr3 repo. I think I can still change the target branch. |
Thanks. I thought about re-styling the already active PR - what do you think? |
also fine, then just make sure you have the deliberate alignment set as I did. After that, we can think of zur other new rules introduced in the tidyverse style guide. |
Like #1, but with updated style guide.