Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix switch with case label 0 #78

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

devnoname120
Copy link
Contributor

@devnoname120 devnoname120 commented Feb 11, 2025

Truthy check instead of undefined/null check, which caused an exception for case 0::

file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/techniques/dynamics/control-flow-unflattening.js:60
            for (const switchCaseNode of switchCaseNodes) {
                                         ^

TypeError: unknown file: switchCaseNodes is not iterable
    at PluginPass.enter (file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/techniques/dynamics/control-flow-unflattening.js:60:42)
    at newFn (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/visitors.js:172:14)
    at NodePath._call (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:49:20)
    at NodePath.call (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:39:18)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:88:31)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitSingle (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:66:19)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:113:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:94:52)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitMultiple (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:62:17)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:111:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:94:52)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitSingle (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:66:19)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:113:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at traverse (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/index.js:53:34)
    at transformFile (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transformation/index.js:80:31)
    at transformFile.next (<anonymous>)
    at run (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transformation/index.js:25:12)
    at run.next (<anonymous>)
    at transform (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transform.js:22:33)
    at transform.next (<anonymous>)
    at evaluateSync (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/gensync/index.js:251:28)
    at sync (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/gensync/index.js:89:14)
    at stopHiding - secret - don't use this - v1 (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/errors/rewrite-stack-trace.js:47:12)
    at transform (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transform.js:36:80)
    at deobfuscate (file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/deobfuscator.js:21:13)
    at file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/deobfuscate.mjs:6:26
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5) {
  code: 'BABEL_TRANSFORM_ERROR'
}
Q                       A
License MIT

Truthy check instead of `undefined`/`null` check, which caused an exception for `case 0:`:

```
file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/techniques/dynamics/control-flow-unflattening.js:60
            for (const switchCaseNode of switchCaseNodes) {
                                         ^

TypeError: unknown file: switchCaseNodes is not iterable
    at PluginPass.enter (file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/techniques/dynamics/control-flow-unflattening.js:60:42)
    at newFn (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/visitors.js:172:14)
    at NodePath._call (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:49:20)
    at NodePath.call (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:39:18)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:88:31)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitSingle (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:66:19)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:113:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:94:52)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitMultiple (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:62:17)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:111:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at NodePath.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/path/context.js:94:52)
    at TraversalContext.visitQueue (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:90:16)
    at TraversalContext.visitSingle (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:66:19)
    at TraversalContext.visit (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/context.js:113:19)
    at traverseNode (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/traverse-node.js:22:17)
    at traverse (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/traverse/lib/index.js:53:34)
    at transformFile (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transformation/index.js:80:31)
    at transformFile.next (<anonymous>)
    at run (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transformation/index.js:25:12)
    at run.next (<anonymous>)
    at transform (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transform.js:22:33)
    at transform.next (<anonymous>)
    at evaluateSync (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/gensync/index.js:251:28)
    at sync (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/gensync/index.js:89:14)
    at stopHiding - secret - don't use this - v1 (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/errors/rewrite-stack-trace.js:47:12)
    at transform (/private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/@babel/core/lib/transform.js:36:80)
    at deobfuscate (file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/node_modules/javascript-deob/src/deobfuscator.js:21:13)
    at file:///private/var/folders/ws/j7hn08fd2w17_q68394mdslr0000gn/T/tmp.nfpgs5x1xR/deobfuscate.mjs:6:26
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:122:5) {
  code: 'BABEL_TRANSFORM_ERROR'
}
```
@lorenzoferre
Copy link
Owner

thank you very much for the fix, I really appreciate it

@lorenzoferre lorenzoferre merged commit 9bbb0c3 into lorenzoferre:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants