-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPP 1.6j Security extension tests #311
OCPP 1.6j Security extension tests #311
Conversation
84c1dbb
to
ac0b6ba
Compare
@lorenzodonini Would you mind reviewing this when you have some time? I would like to get this merged, as currently there are no tests for the security extension |
Thanks for adding the tests! I'm a big fan of not committing auto-generated files and rather generate them on-the-fly (it just needs to be documented in the README). Any specific reason you prefer checking them in? |
No particular reason, I'll set up a pipeline for that. Edit: Come to think of it, I think I might have misunderstood the whole sentence. Basically, instead of manually writing mocks like in Since tests are based on generated mocks and mocks are generated from interfaces (which can change), they should be included in the commit. The tests will fail anyway if mocks arent up to date. |
e2a417b
to
f0c3211
Compare
@lorenzodonini I've managed to create a CI pipeline for autogenerating mocks. One known issue with the pipeline currently is failure at commit files step because of the refs: Another potential could be adding newly generated files to VCS from the workflow. For some reason, the GH action format validation fails if I try to pass inputs to It should be good enough for an initial version, and I'll try to fix these issues asap. |
730f16c
to
e00361c
Compare
91145e8
to
713f2a5
Compare
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments