Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds additional boards: Gualtherius LoRaHam #189

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Adds additional boards: Gualtherius LoRaHam #189

merged 9 commits into from
Nov 16, 2022

Conversation

fkaup
Copy link
Contributor

@fkaup fkaup commented Apr 21, 2022

fkaup added 2 commits April 21, 2022 20:24
@fkaup
Adds additional boards: Gualtherius LoRaHam
657cfd7 
More information:
https://gualtherius.de/product_info.php?products_id=8
@fkaup
Uses GPIO to power OLED display
93324c6 
defined in is-cfg.json as
display -> pin_vcc
display -> pin_gnd

currently configured on main thread. Should probably be moved to display initialization.
@peterus
Copy link
Member

peterus commented May 7, 2022

@fkaup please update your merge request, there was already a change in the board file.

@peterus peterus added the question Further information is requested label May 7, 2022
@fkaup
Copy link
Contributor Author

fkaup commented Oct 24, 2022

merge conflict resolved

@peterus
Copy link
Member

peterus commented Oct 30, 2022

I have two questions:

  1. using gpio pins for vcc and gnd is not a good way to deliver power to a display. because a gpio pin can never give the power to a display.
  2. why do you set the vcc and gnd pins two time in the code? one time should be enough.

@fkaup
Copy link
Contributor Author

fkaup commented Nov 1, 2022

  1. tested and works at least for the small OLED displays :) - but I agree that it's not nice.. but allows to connect the display directly to the header instead of using wires.
  2. good spot. Had a merge conflict before and must have missed that.

@peterus
Copy link
Member

peterus commented Nov 16, 2022

@fkaup i removed your vcc and gnd pin approach as I personally don't like it. Of course you can use it in your branch. But I have the feeling that also some boards can be destroid with this.

@peterus peterus enabled auto-merge November 16, 2022 20:54
@peterus
Copy link
Member

peterus commented Nov 16, 2022

@fkaup thanks for the new board :)

@peterus peterus merged commit 0fca206 into lora-aprs:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkaup @peterus