Skip to content

Commit

Permalink
Merge branch 'microsoft:master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
longhuan2018 authored Nov 24, 2023
2 parents b21ae07 + cd5e746 commit de10fd0
Show file tree
Hide file tree
Showing 6,985 changed files with 106,625 additions and 59,161 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
47 changes: 47 additions & 0 deletions .github/ISSUE_TEMPLATE/00-report-package-build-failure.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Report package build failure
description: Let us know about build failures in ports.
title: "[<port name>] build failure"
labels: ["category:port-bug"]
body:
- type: markdown
attributes:
value: |
⚠ Please use the generated issue template instead to report a port build failure. ⚠ <br>
See [here](https://github.com/microsoft/vcpkg/issues/30604) how to properly report an issue with the latest vcpkg version:
<video width="800" controls="controls" muted="muted" src="https://user-images.githubusercontent.com/41973254/229313721-b82c2d3d-b0f9-4e31-98df-08d75831f695.mp4"></video>
- type: input
id: os
attributes:
label: Operating system
placeholder: "e.g. Windows/Linux etc..."
validations:
required: true
- type: input
id: compiler
attributes:
label: Compiler
placeholder: "GCC, Clang, MSVC, MinGW, ..."
validations:
required: false
- type: textarea
id: reproduce
attributes:
label: Steps to reproduce the behavior
placeholder: "`./vcpkg install xxxx`"
render: "Shell"
validations:
required: true
- type: textarea
id: logs
attributes:
label: Failure logs
description: The console output and all the logs metioned in the output
validations:
required: true
- type: textarea
id: context
attributes:
label: Additional context
description: Add any other context about the problem here, such as what you have already tried to resolve the issue.
validations:
required: false
36 changes: 36 additions & 0 deletions .github/ISSUE_TEMPLATE/01-request-a-new-port.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Request a new port
description: Request a new port/library that vcpkg should support
title: "[New Port Request] <library name here>"
labels: ["category:new-port", "info:good-first-issue"]

body:
- type: input
id: name
attributes:
label: Library name
validations:
required: true
- type: input
id: description
attributes:
label: Library description
validations:
required: false
- type: input
id: url
attributes:
label: Source repository URL
validations:
required: true
- type: input
id: homepage
attributes:
label: Project homepage (if different from the source repository)
validations:
required: false
- type: textarea
id: additional-info
attributes:
label: Anything else that is useful to know when adding (such as optional features the library may have that should be included)
validations:
required: false
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Request an update to an existing port
description: Let us know about a new version of a library we should pick up.
title: "[<port name>] update to <version>"
labels: ['category:port-update']
body:
- type: input
id: name
attributes:
label: Library name
validations:
required: true
- type: input
id: version
attributes:
label: New version number
validations:
required: true
- type: textarea
id: information
attributes:
label: Other information that may be useful (release notes, etc...)
validations:
required: false
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Request a feature or improvement to a port
description: Suggest an improvement to one the the ports/libraries in vcpkg
title: "[<portname>] <short description of feature>"
labels: ["category:port-feature"]
body:
- type: textarea
attributes:
label: Is your feature request related to a problem? Please describe.
placeholder: A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
validations:
required: true
- type: textarea
attributes:
label: Proposed solution
placeholder: A clear and concise description of what you want to happen.
validations:
required: true
- type: textarea
attributes:
label: Describe alternatives you've considered
placeholder: A clear and concise description of any alternative solutions or features you've considered if applicable.
validations:
required: false
- type: textarea
attributes:
label: Additional context
placeholder: Add any other context or screenshots about the feature request here.
validations:
required: false
29 changes: 29 additions & 0 deletions .github/ISSUE_TEMPLATE/04-request-a-feature-or-improvement.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Request a feature or improvement
description: Suggest an improvement to vcpkg
title: ''
labels: ["category:vcpkg-feature"]
body:
- type: textarea
attributes:
label: Is your feature request related to a problem? Please describe.
placeholder: A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
validations:
required: true
- type: textarea
attributes:
label: Proposed solution
placeholder: A clear and concise description of what you want to happen.
validations:
required: true
- type: textarea
attributes:
label: Describe alternatives you've considered
placeholder: A clear and concise description of any alternative solutions or features you've considered.
validations:
required: false
- type: textarea
attributes:
label: Additional context
placeholder: Add any other context or screenshots about the feature request here.
validations:
required: false
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: I have a question
url: https://github.com/microsoft/vcpkg/discussions
about: Please ask and answer questions here.
10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/i-have-a-question.md

This file was deleted.

33 changes: 0 additions & 33 deletions .github/ISSUE_TEMPLATE/report-package-build-failure.md

This file was deleted.

This file was deleted.

22 changes: 0 additions & 22 deletions .github/ISSUE_TEMPLATE/request-a-feature-or-improvement.md

This file was deleted.

18 changes: 0 additions & 18 deletions .github/ISSUE_TEMPLATE/request-a-new-port.md

This file was deleted.

14 changes: 0 additions & 14 deletions .github/ISSUE_TEMPLATE/request-an-update-to-an-existing-port.md

This file was deleted.

6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<!-- If this PR updates an existing port, please uncomment and fill out this checklist:
- [ ] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md)
- [ ] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md)
- [ ] SHA512s are updated for each updated download
- [ ] The "supports" clause reflects platforms that may be fixed by this new version
- [ ] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.
Expand All @@ -16,14 +16,14 @@ END OF PORT UPDATE CHECKLIST (delete this line) -->

<!-- If this PR adds a new port, please uncomment and fill out this checklist:
- [ ] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md)
- [ ] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md)
- [ ] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
- [ ] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all `find_package` calls are REQUIRED, are satisfied by `vcpkg.json`'s declared dependencies, or disabled with [CMAKE_DISABLE_FIND_PACKAGE_Xxx](https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html)
- [ ] The versioning scheme in `vcpkg.json` matches what upstream says.
- [ ] The license declaration in `vcpkg.json` matches what upstream says.
- [ ] The installed as the "copyright" file matches what upstream says.
- [ ] The source code of the component installed comes from an authoritative source.
- [ ] The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
- [ ] The generated "usage text" is accurate. See [adding-usage](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/examples/adding-usage.md) for context.
- [ ] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result.
- [ ] Only one version is in the new port's versions file.
- [ ] Only one version is added to each modified port's versions file.
Expand Down
44 changes: 44 additions & 0 deletions .github/workflows/check_issues.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Check For Common Issues

on:
issues:
types:
- opened

jobs:
check-for-common-issues:
runs-on: ubuntu-latest
permissions:
issues: write
steps:
- uses: actions/github-script@v6
with:
script: |
let issue_query = {
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo
};
let issue = await github.rest.issues.get(issue_query)
// missing-windows-sdk-issue
let reg = /RC Pass 1: command "rc .*" failed \(exit code 0\) with the following output:/;
if (reg.test(issue.data.body)){
await github.rest.issues.removeAllLabels(issue_query);
await github.rest.issues.setLabels({...issue_query, labels: ["category:question"]});
let body = "Thanks for posting this issue. Please make sure you have the following installed.\n" +
"- Visual Studio Desktop development with C++.\n" +
"- Windows 10 SDK or Windows 11 SDK.";
await github.rest.issues.createComment({...issue_query, body});
// Close the issue?
}
// msys2 download fails => old vcpkg version
reg = /error: https:\/\/repo\.msys2\.org\/.*: failed: status code 404/;
if (reg.test(issue.data.body)){
await github.rest.issues.removeAllLabels(issue_query);
await github.rest.issues.setLabels({...issue_query, labels: ["category:question"]});
let body = "Try updating your vcpkg version via `git pull` to resolve this issue. MSYS2 downloads are removed from the upstream servers from time to time, so using an up-to-date vcpkg version is necessary."
await github.rest.issues.createComment({...issue_query, body});
// Close the issue?
}
Loading

0 comments on commit de10fd0

Please sign in to comment.