(WIP) feat: add QoS control to throttle resource usage during rebuilding #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lding Signed-off-by: jinhong.kim0 <[email protected]>
shuo-wu
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Would you create a separate PR for API BdevSetQosLimit in repo https://github.com/longhorn/go-spdk-helper.
As for the rebuilding-related modification in github.com/longhorn/longhorn-spdk-engine/pkg/spdk/replica.go, I think it's better to make the QoS configurable rather than using fixed numbers. Besides, we should create a separate PR in repo https://github.com/longhorn/longhorn-spdk-engine as well.
|
Thank you so much for reviewing my PR @shuo-wu As you suggested, I will separate the changes into the appropriate repositories. For now, I included everything in a single repository just to prototype the implementation more easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#10770
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context