fix: do not allow total all kind of snapshots to be bigger than 250 (backport #1405)

[mergify]

longhorn/longhorn#10308

Special notes for your reviewer:

The dependent PR is at longhorn/types#45

Additional documentation or context

This PR is an alternative proposal to the PR #1404. Why?

1. This PR will fix the total snapshot count issue
2. It still keeping the previous behavior of the snapshot enforcement feature the same. A.K.A the following case still work:
   1. User create a volume with backing image
   2. User set maximum snapshot count for the volume to be 2
   3. Longhorn allows user to take 2 more snapshot. If we use the PR fix: not allow more than 250 snapshots including all kind of snapshots #1404, Longhorn would not allow user to take any more snapshot which might be a behavior change, or confusion, or regression

---

This is an automatic backport of pull request #1405 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of 8bf0b1d has failed:

On branch mergify/bp/v1.6.x/pr-1405
Your branch is up to date with 'origin/v1.6.x'.

You are currently cherry-picking commit 8bf0b1d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   app/cmd/controller.go
	modified:   app/cmd/replica.go
	modified:   go.mod
	modified:   pkg/backend/file/file.go
	modified:   pkg/backend/remote/remote.go
	modified:   pkg/controller/control.go
	modified:   pkg/controller/replicator.go
	modified:   pkg/replica/client/client.go
	modified:   pkg/replica/rpc/server.go
	modified:   pkg/types/resource.go
	modified:   pkg/types/types.go
	modified:   vendor/modules.txt

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   go.sum
	both modified:   pkg/replica/replica.go
	deleted by us:   vendor/github.com/longhorn/types/pkg/generated/enginerpc/replica.pb.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[derekbit]

@PhanLe1010 Need to fix the conflicts.

[derekbit]

After discussing with @innobead, no need to backport to v1.7.x because of

• low severity (3)
• longhorn/types has breaking change