New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds empty alt text for placeholder image. #634

Merged

lokesh merged 1 commit into lokesh:dev from Nhawdge:Develop/AddAltText

Apr 20, 2019

Nhawdge commented Dec 5, 2018

Pull Requests are welcome. But note that v2 of Lightbox is in Maintenance Mode and no new features
will be added. See the Roadmap.

PRs submitted will still be reviewed and then kept open for other users to utilize.

I've added an empty alt text to the place holder image to prevent screen readers from reading this.


          Adds empty alt text for placeholder image.

11d64b2

Owner

lokesh commented Apr 20, 2019

Just saw this. Great technique. I had no idea that the entire image url would be read if the alt attr was left out.

Updating. 🙏

lokesh merged commit dd0e5fb into lokesh:dev

lokesh mentioned this pull request

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet