Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add client package #329

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

wangsijie
Copy link
Contributor

Summary

Extract 3 platform-related parts from @logto/browser and get a new package @logto/client:

  1. requester
  2. storage
  3. handleRedirect

Next action: refactor @logto/browser to extend @logto/client.

Testing

Passed all UTs.

@linear
Copy link

linear bot commented Jul 11, 2022

@wangsijie wangsijie force-pushed the sijie-log-3579-client-package branch 2 times, most recently from 05bac4b to 887f3d4 Compare July 11, 2022 09:14
@wangsijie wangsijie force-pushed the sijie-log-3579-client-package branch from 887f3d4 to 43b439f Compare July 11, 2022 09:29
Copy link
Contributor

@xiaoyijun xiaoyijun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering do we miss the crypto part? also TextEncoder.

@wangsijie
Copy link
Contributor Author

@xiaoyijun yes, crypto and textEncoder is in LOG-3616

@wangsijie wangsijie merged commit 04c7b56 into master Jul 12, 2022
@wangsijie wangsijie deleted the sijie-log-3579-client-package branch July 12, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants