refactor(js)!: initialize js/js package #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceHe
force-pushed
the
icehe-log-1329
branch
3 times, most recently
from
40a4e73 to
38fd475
Compare
gao-sun
reviewed
Jan 14, 2022
gao-sun
reviewed
Jan 14, 2022
There was a problem hiding this comment.
Overall LGTM @simeng-li would you like to do the final stamp?
simeng-li
reviewed
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initialize
js/jspackage(contains temporary content for
pnpm buildto pass CI)(contains temporary content for
pnpm testto pass CI)Next up: Move the core and util functions from
js/clientto `js/jsLinear Issue Reference
LOG-1329
Testing
None for now in js/js
@logto-io/eng