fix(browser): remove session item after successful sign-in

logto-io · Apr 28, 2022 · f33bcd2 · f33bcd2
1 parent 28ccd8e
commit f33bcd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/browser/src/index.test.ts b/packages/browser/src/index.test.ts
@@ -30,6 +30,7 @@ const mockedSignInUri = generateSignInUri({
 
 const refreshTokenStorageKey = `logto:${appId}:refreshToken`;
 const idTokenStorageKey = `logto:${appId}:idToken`;
+const signInSessionStorageKey = `logto:${appId}`;
 
 const accessToken = 'access_token_value';
 const refreshToken = 'new_refresh_token_value';
@@ -200,11 +201,13 @@ describe('LogtoClient', () => {
       const code = `code_value`;
       const callbackUri = `${redirectUri}?code=${code}&state=${mockedState}&codeVerifier=${mockedCodeVerifier}`;
 
+      expect(sessionStorage.getItem(signInSessionStorageKey)).not.toBeNull();
       await expect(logtoClient.handleSignInCallback(callbackUri)).resolves.not.toThrow();
       await expect(logtoClient.getAccessToken()).resolves.toEqual(accessToken);
       expect(localStorage.getItem(refreshTokenStorageKey)).toEqual(refreshToken);
       expect(localStorage.getItem(idTokenStorageKey)).toEqual(idToken);
       expect(requester).toHaveBeenCalledWith(tokenEndpoint, expect.anything());
+      expect(sessionStorage.getItem(signInSessionStorageKey)).toBeNull();
     });
   });
 

diff --git a/packages/browser/src/index.ts b/packages/browser/src/index.ts
@@ -268,6 +268,7 @@ export default class LogtoClient {
     await this.verifyIdToken(codeTokenResponse.idToken);
 
     this.saveCodeToken(codeTokenResponse);
+    this.signInSession = null;
   }
 
   public async signOut(postLogoutRedirectUri?: string) {