fix: remove deperecated role names (#442)

logto-io · Feb 10, 2023 · ae44b63 · ae44b63
1 parent 0640e70
commit ae44b63
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 21 deletions.
diff --git a/packages/js/src/core/user-info.ts b/packages/js/src/core/user-info.ts
@@ -10,7 +10,6 @@ export type UserInfoResponse = {
   name?: string;
   username?: string;
   picture?: string;
-  role_names?: string[];
   email?: string;
   email_verified?: boolean;
   phone_number?: string;

diff --git a/packages/js/src/utils/id-token.test.ts b/packages/js/src/utils/id-token.test.ts
@@ -213,7 +213,7 @@ describe('verifyIdToken', () => {
 describe('decodeIdToken', () => {
   test('decoding valid JWT should return claims', async () => {
     const { privateKey } = await generateKeyPair('RS256');
-    const jwt = await new SignJWT({ name: '测试用户', avatar: undefined, role_names: ['admin'] })
+    const jwt = await new SignJWT({ name: '测试用户', avatar: undefined })
       .setProtectedHeader({ alg: 'RS256' })
       .setIssuer('foo')
       .setSubject('bar')
@@ -229,13 +229,12 @@ describe('decodeIdToken', () => {
       exp: 2000,
       iat: 1000,
       name: '测试用户',
-      role_names: ['admin'],
     });
   });
 
   test('decoding valid JWT with wrong payload type should throw', async () => {
     const { privateKey } = await generateKeyPair('RS256');
-    const jwt = await new SignJWT({ name: null, avatar: undefined, role_names: [123] })
+    const jwt = await new SignJWT({ name: null, avatar: undefined, at_hash: 123 })
       .setProtectedHeader({ alg: 'RS256' })
       .setIssuer('foo')
       .setSubject('bar')

diff --git a/packages/js/src/utils/id-token.ts b/packages/js/src/utils/id-token.ts
@@ -20,7 +20,6 @@ export type IdTokenClaims = {
   email_verified?: boolean;
   phone_number?: Nullable<string>;
   phone_number_verified?: boolean;
-  role_names?: Nullable<string[]>;
 };
 
 /* eslint-disable complexity */
@@ -63,22 +62,6 @@ function assertIdTokenClaims(data: unknown): asserts data is IdTokenClaims {
       throw new TypeError(`At path: IdToken.${key}: expected a boolean`);
     }
   }
-
-  if (
-    data.role_names !== undefined &&
-    data.role_names !== null &&
-    !Array.isArray(data.role_names)
-  ) {
-    throw new TypeError('At path: IdToken.role_names: expected null or an array of strings');
-  }
-
-  if (data.role_names) {
-    for (const [index, value] of data.role_names.entries()) {
-      if (typeof value !== 'string') {
-        throw new TypeError(`At path: IdToken.role_names[${index}]: expected a string`);
-      }
-    }
-  }
 }
 /* eslint-enable complexity */