Updated Kibana Dashboard Loader #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2024 06:27
shubham-naruka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is about replacing the old static loader in the Kibana dashboard and replacing it with a new gif file.
Dependencies
• None
Breaking Change
• [ ] Yes
• [X] No
Visuals
• None
Testing Notes
What I did:
I updated the loader in the Kibana dashboard.
What did you do to validate this PR?
Try rebuilding the Kibana in the dev box and after installing the Kibana build restart the Kibana service you will be able to see the changes.
How you can replicate my testing:
Try rebuilding the Kibana in the dev box and after installing the Kibana build restart the Kibana service you will be able to see the changes.
How can the reviewer validate this PR?
By testing the UI by seeing the loader in the Kibana dashboard
Before changes
After changes
Jira Link
https://logrhythm.atlassian.net/browse/ENG-57733