Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-flag-to-not-send-goal-in-BTactionnode #13

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

tonynajjar
Copy link

  • Added a flag to not send goal in BtActionNode

Signed-off-by: Owen Hooper [email protected]

  • Fixed cpplint and uncrustify issues.

  • Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_node.hpp

Signed-off-by: Owen Hooper [email protected]
Co-authored-by: Steve Macenski [email protected]
(cherry picked from commit 8e7090b)


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

* Added a flag to not send goal in BtActionNode

Signed-off-by: Owen Hooper <[email protected]>

* Fixed cpplint and uncrustify issues.

* Update nav2_behavior_tree/include/nav2_behavior_tree/bt_action_node.hpp

Signed-off-by: Owen Hooper <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
(cherry picked from commit 8e7090b)
@tonynajjar
Copy link
Author

tonynajjar commented Feb 28, 2023

This will allow to not send a goal from the on_tick() of our BT action nodes (e.g. if input validation fails). It's already on master, just backporting it in our fork

Copy link

@HovorunB HovorunB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@tonynajjar tonynajjar merged commit f8fdce3 into humble Feb 28, 2023
@tonynajjar
Copy link
Author

@jplapp @andriimaistruk merging as this is simply a backport but feel free to leave comments

@tonynajjar
Copy link
Author

FYI opened https://github.com/ros-planning/navigation2/pull/3431/files to enable in for BTServiceNode as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants