Put all code related to RS in the same file #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andres-MG
added
enhancement
Andres-MG
force-pushed
the
refactor
branch
2 times, most recently
from
c4718ab to
e76d7c5
Compare
|
If the test cases are ok, go ahead and merge with master |
The code for the Riemann solvers was scattered between the PhysicsStorage, HyperbolicDiscretization and RiemannSolvers files. I have moved everything to RiemannSolvers, adding a describe function to avoid rewriting the same thing in all hyperbolic discretizations.
Before this fix we were adding `#end` as one of the keywords in the global variables dictionary. This does not affect simulations, but the implementation was wrong.
Andres-MG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for the Riemann solvers was scattered between the PhysicsStorage, HyperbolicDiscretization and RiemannSolvers files. I have moved everything to RiemannSolvers, adding a describe function to avoid rewriting the same thing in all hyperbolic discretizations.
This PR could be a good opportunity to improve the quality of the code. If someone has suggestions, please comment them here so we can add them to the final merge.