feat: Add base config override

[YOU54F]

Hi,

Just wondered if you would be interested in a proposal to include the ability to custom configure the config_base for the app.

I have got this working with the pact_broker app, however I pull in the config from another repo, into a pact_broker folder, and rather than changing any references in that code, it would be handy to change the config base.

This is a bit of a hack for now, but it worked, happy to make it a bit cleaner, and more in link with existing rack custom vars if you would be happy to consider

PS, thank you for the great project and top docs!

Thanks!

[codecov]

Codecov Report

Merging #4 into master will decrease coverage by 0.2%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage     100%   99.79%   -0.21%     
==========================================
  Files           5        5              
  Lines         487      496       +9     
  Branches       60       64       +4     
==========================================
+ Hits          487      495       +8     
- Misses          0        1       +1

Impacted Files	Coverage Δ
index.js	100% <100%> (ø)	⬆️
lib/rack_adapter.rb	90% <75%> (-10%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbba7cf...7497849. Read the comment docs.

[logandk]

Hi @YOU54F, thanks for the PR! It makes sense to make the Rack config path configurable. RACK_CONFIG_BASE isn't a standard Rack-thing, right? Because there's also the option of making this a setting in serverless.yml, which I would prefer for consistency - except if we have a standardized Rack-counterpart, in which case we should follow that convention.

[YOU54F]

Hey bud, no it’s not a standard rack env var. I will pop it into a custom rack var to follow the format of your other config options and add readme instructions

[logandk]

Awesome 👍 The config gets written from here: https://github.com/logandk/serverless-rack/blob/master/index.js#L89

[YOU54F]

Hey mate,

I reckon this is good for review now,

I have tested it on this branch/PR in one of my github projects

pact-foundation/pact_broker-serverless#13

Running on a lambda here

https://you54f.co.uk/

Cheers!

[logandk]

@YOU54F Great work, much appreciated! I'll review the changes and do a release as soon as possible

[YOU54F]

@YOU54F Great work, much appreciated! I'll review the changes and do a release as soon as possible

Brill, no rush my friend!

[logandk]

It's merged now - I changed set setting name to configPath since it's basically just the Rack configuration file and not going to be inherited by some final configuration file - hope you agree. Again, thanks for your work!

[YOU54F]

That’s makes perfect sense mate, much appreciated. I’ll test it out later and report back just to close the loop.

Thanks again for the package, glad to help out :)