Display output from child Docker process #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 5 5
Lines 563 563
Branches 78 78
=======================================
Hits 553 553
Misses 10 10
Continue to review full report at Codecov.
|
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On running this for the first time, I didn't have the
'logandk/serverless-rack-bundlerimage locally, so Docker of course had to pull it first. Unfortunately, Docker's stdout wasn't being displayed, so I was left staring atServerless: Packaging gem dependencies using docker...and wondering if something had broken. This PR makes sure the user knows what's going on with Docker behind the scenes.