Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles empty API_GATEWAY_BASE_PATH #14

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Jul 11, 2020

When API_GATEWAY_BASE_PATH is empty, this causes duplicate slashes at the beginning of the path (e.g. //my/path).

This update handles empty and null values for API_GATEWAY_BASE_PATH.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #14 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.81%   99.81%   -0.01%     
==========================================
  Files           5        5              
  Lines         536      535       -1     
  Branches       73       73              
==========================================
- Hits          535      534       -1     
  Misses          1        1              
Impacted Files Coverage Δ
lib/serverless_rack.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050463d...76c14c7. Read the comment docs.

@logandk
Copy link
Owner

logandk commented Oct 24, 2020

Thanks a lot for the PR! I'm very sorry about the long response time, but I have not been able to free up time for this project in a while.

@logandk logandk merged commit d28fedd into logandk:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants