Fix GPG Agent forwarding broken

e2e/framework/command.go

@@ -266,18 +266,22 @@ func (f *Framework) SetupGPG(tmpDir string) error {
 func (f *Framework) DevPodSSHGpgTestKey(ctx context.Context, workspace string) error {
 	pubKeyB, err := exec.Command("sh", "-c", "gpg -k --with-colons 2>/dev/null | grep sec | base64 -w0").Output()
 	if err != nil {
-		return nil
+		return err
 	}
 
 	// First run to trigger the first forwarding
-	stdout, _, _ := f.ExecCommandCapture(ctx, []string{
+	stdout, _, err := f.ExecCommandCapture(ctx, []string{
 		"ssh",
 		"--agent-forwarding",
 		"--gpg-agent-forwarding",
 		"--command",
 		"gpg -k --with-colons 2>/dev/null |grep sec |  base64 -w0", workspace,
 	})
 
+	if err != nil {
+		return err
+	}
+
 	if stdout != string(pubKeyB) {
 		return fmt.Errorf("devpod gpg public key forwarding failed, expected %s, got %s", string(pubKeyB), stdout)
 	}

e2e/tests/ssh/ssh.go

@@ -51,6 +51,11 @@ var _ = DevPodDescribe("devpod ssh test suite", func() {
 		})
 
 		ginkgo.It("should start a new workspace with a docker provider (default) and forward gpg agent into it", func() {
+			// skip windows for now
+			if runtime.GOOS == "windows" {
+				return
+			}
+
 			tempDir, err := framework.CopyToTempDir("tests/ssh/testdata/gpg-forwarding")
 			framework.ExpectNoError(err)
 			defer framework.CleanupTempDir(initialDir, tempDir)

pkg/driver/docker/docker.go

@@ -251,21 +251,10 @@ func (d *dockerDriver) RunDockerDevContainer(
 	}
 
 	// mounts
-	tmpfsMount := true
 	for _, mount := range options.Mounts {
-		// skip tmpfs mount on /tmp if devcontainer specifies another mount option
-		if strings.Contains(mount.String(), "destination=/tmp") ||
-			strings.Contains(mount.String(), "target=/tmp") {
-			tmpfsMount = false
-		}
 		args = append(args, "--mount", mount.String())
 	}
 
-	// ensure /tmp is a tmpfs like on regular linux distros
-	if tmpfsMount {
-		args = append(args, "--mount", "type=tmpfs,destination=/tmp")
-	}
-
 	// add ide mounts
 	switch ide {
 	case string(config2.IDEGoland):