Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pro): auto-mount kubeconfig of virtual cluster/space instance into workspace #1609

Conversation

pascalbreuninger
Copy link
Member

No description provided.

@pascalbreuninger pascalbreuninger requested a review from a team January 31, 2025 17:33
@pascalbreuninger pascalbreuninger force-pushed the feat/POD-1296-auto-mount-kubeconfig branch 2 times, most recently from ff18716 to 37ccfe3 Compare January 31, 2025 17:39
pkg/platform/kubeconfig.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean code, just a couple of minor remarks

@pascalbreuninger pascalbreuninger force-pushed the feat/POD-1296-auto-mount-kubeconfig branch from 37ccfe3 to ca121af Compare February 3, 2025 13:01
@pascalbreuninger pascalbreuninger merged commit 02a89b6 into loft-sh:main Feb 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants