Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent ambiguous configuration for options #1392

Merged
merged 1 commit into from
Dec 10, 2024
Merged

prevent ambiguous configuration for options #1392

merged 1 commit into from
Dec 10, 2024

Conversation

abdulari
Copy link
Contributor

prevent user from running ambiguous command such as:

vscode ➜ /workspaces/devpod (main) $ devpod provider options docker --provider docker2  --debug
10:05:21 info providerName=docker
10:05:21 info GlobalFlags.Provider=docker2
10:05:21 fatal ambiguous provider configuration detected
vscode ➜ /workspaces/devpod (main) $

@abdulari abdulari force-pushed the abdulari/prevent-ambiguous-config branch from 09b3c5f to 98f1663 Compare November 17, 2024 15:27
pascalbreuninger
pascalbreuninger approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, LGTM! 👍

@lentzi90 lentzi90 mentioned this pull request Dec 10, 2024
Merged
@pascalbreuninger pascalbreuninger merged commit bf111db into loft-sh:main Dec 10, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalbreuninger pascalbreuninger pascalbreuninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulari @pascalbreuninger