Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct fail ratio calculation. Fixes #991. #994

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Correct fail ratio calculation. Fixes #991. #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locust/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def log_error(self, error):
@property
def fail_ratio(self):
try:
return float(self.num_failures) / (self.num_requests + self.num_failures)
return float(self.num_failures) / self.num_requests
except ZeroDivisionError:
if self.num_failures > 0:
return 1.0
Expand Down
12 changes: 12 additions & 0 deletions locust/test/test_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,18 @@ def test_diff_response_times_dicts(self):
))


class TestStatsEntry(unittest.TestCase):
def setUp(self, *args, **kwargs):
super(TestStatsEntry, self).setUp(*args, **kwargs)
self.stats = RequestStats()

def test_fail_ratio_with_failures(self):
s = StatsEntry(self.stats, "/", "GET")
s.num_requests = 10
s.num_failures = 5
self.assertAlmostEqual(s.fail_ratio, 0.5)


class TestRequestStatsWithWebserver(WebserverTestCase):
def test_request_stats_content_length(self):
class MyLocust(HttpLocust):
Expand Down