Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.0 #867

Merged
merged 4 commits into from
Sep 1, 2018
Merged

Release 0.9.0 #867

merged 4 commits into from
Sep 1, 2018

Conversation

aldenpeterson-wf
Copy link
Contributor

Resolves #842

This also adds the automatic generation of the Changelog using github_changelog_generator. This will mean a few things:

  1. We will want to be more clear about having detailed PR descriptions as they are automatically added
  2. We could choose to not include closed issues without labels to have less clutter. I left (allthethings) here since this is the first changelog generation
  3. In the future, releases will be much easier and can happen more frequently because this tool makes it trivial to generate release notes
  4. We could replace the entire web changelog with the autogenerated one - I left it as a highlights and link to the full changelog. Thoughts?

When this is merged, someone with pypi access will have to publish the package (as well as tag; I'm not doing so until this is merged and someone else might beat me to it).

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #867 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #867   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          14       14           
  Lines        1438     1438           
  Branches      226      226           
=======================================
  Hits          957      957           
  Misses        430      430           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6701f70...24a52c3. Read the comment docs.

Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - :shipit: 🚢 ?

Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. Can you add a target to the Makefile for this, so we can make changelog?


* Run github_changelog_generator to update `CHANGELOG.md`
* update `locust/__init__.py` with new version number: `__version__ = "0.9.0.rc1"`
* set milestone to 0.9.0 on all included PR's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this.

* Run github_changelog_generator to update `CHANGELOG.md`
* update `locust/__init__.py` with new version number: `__version__ = "0.9.0.rc1"`
* set milestone to 0.9.0 on all included PR's
* update changelog in docs: `locust/docs/changelog.rst`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well right now that changelog is still cherry picked - I could update it and say "this is the last release with a changelog manually curated" though and then leave a link to the autogenerated one.

@aldenpeterson-wf
Copy link
Contributor Author

@cgoldberg I didn't add a Makefile target since right now it's still requiring a manual update step for the curated changelog.

If that ends up being archived, it'd be easier (could literally do make release 0.9.0 type of syntax).

@aldenpeterson-wf
Copy link
Contributor Author

@heyman @cgoldberg @mbeacom

Anything we can do to speed this along? A ton of people have been asking about the next release and it'd be nice to get this released.

@anhpham1509
Copy link

Ping @heyman and @cgoldberg if you have time to do the release this week?

@aldenpeterson-wf
Copy link
Contributor Author

Can we please have someone with pypi access release this?

We want to use this functionality internally and I don't really want to have to fork/mirror Locust just to be able to let people use functionality that has been in master for almost a year at this point.

I don't even know who to ping at this point to get this released.

@cgoldberg
Copy link
Member

i'm going to try to do it tomorrow.

@cgoldberg cgoldberg merged commit 4bde2ca into locustio:master Sep 1, 2018
@cgoldberg
Copy link
Member

just released 0.9.0 to PyPI:
https://pypi.org/project/locustio/0.9.0/

🎉

done:

  • updated Makefile
  • landed this PR
  • tagged 0.9.0
  • built source and wheel distributions
  • uploaded dists to PyPI

spayeur207 pushed a commit to spayeur207/locust that referenced this pull request Sep 12, 2018
* Release 0.9.0

* Release 0.9.0 review comments

* Release 0.9.0 - add changelog generator instructions

* More changelog highlights for 0.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.9.0 and document release steps
5 participants