Add failure rate chart to charts #720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2018 16:35
Adds a failure rate chart. Also corrected 95% to 95th
Also nicely adds optional min/max to charts
|
Would love to see this merged in. The jenkins build looks like it only failed on the connection to pypi. A rerun of the build should clear it up. |
|
This would be so good to see this feature alive |
|
@thomas-phillips-nz Could you look into the conflicts? If you resolve them I'd be happy to merge this. |
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 18 18
Lines 1810 1810
Branches 273 273
=======================================
Hits 1356 1356
Misses 388 388
Partials 66 66Continue to review full report at Codecov.
|
|
This will be superseeded by #588 (or rather, its successor), as having the failure rate in the same graph as the success rate is much better imho :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a chart of failure ratio over time.
This with #693 looks to be getting to too many charts 😟
Maybe someone with good JS skills should add a drop-down list of possible charts??