Remove --num-requests/-n in favor of --run-time/-t #656

heyman · 2017-09-18T12:57:40Z

This adds the --run-time/-t option that can be used, together with --no-web, to specify the run time of a test. It also removes the -n/--num-requests option as discussed in #196 and #512 (which can both be closed once this is merged).

…specify how long a test should run

aldenpeterson-wf · 2017-09-18T18:13:15Z

locust/util/time.py

+    timespan_regex = re.compile(r'((?P<hours>\d+?)h)?((?P<minutes>\d+?)m)?((?P<seconds>\d+?)s)?')
+    parts = timespan_regex.match(time_str)
+    if not parts:
+        raise ValueError("Invalid time span format")


small nit: it'd be nice if this message showed the valid or expected formats from the docstring

aldenpeterson-wf · 2017-09-18T18:13:45Z

This should probably be added to the docs too, but this looks great and something we will definitely want to use 👍

Moved info on how to run Locust without the web UI, and how to retrieve CSV stats, into their own documentation pages. Added info about --time-limit option. Added info about --expect-slaves option.

heyman · 2017-09-19T13:02:01Z

Thanks! I've now added info to the documentation (very good point :)).

I actually ended up restructuring the docs a bit, by moving out info on how to run Locust without the web UI, as well as how to retrieve CSV stats, into their own pages. It didn't really belong on the Quickstart page, and now it'll be easier to find directly from the docs index page.

I'll go ahead and merge this.

waberc · 2018-09-27T13:07:45Z

locust/main.py

+
+    if options.run_time:
+        if not options.no_web:
+            logger.error("The --run-time argument can only be used together with --no-web")


Why does it forbid this option if we are working from the web console ?

In my use-case I would find it super useful to be able to start the test from the web, and have it stopping automatically even when I am disconnected / in a meeting after some time or when I hit the stop button. This would avoid me forgetting to stop the test and act as security to avoid a test running for ever...

Am I the only one who would like this feature not restricted to the --no-web ? Should I create an issue / feature request ?

We would want this feature to be used with the web interface too, would be very useful.

rk4n3 · 2019-08-23T07:01:12Z

Why was the -n/--num-requests removed ? Both mechanisms have distinct value/usage-scenarios, and I am one that really needs the -n/--num-requests capability.

In short, a particular test (with plenty of sophistication in its design/operation) is needed for both typical load testing scenario, AND a separate scenario where a single execution must execute and exit as quickly as possible.

Can we restore the lost functionality ?

PraveenWhatfix · 2019-08-23T08:59:13Z

Why was the -n/--num-requests removed ? Both mechanisms have distinct value/usage-scenarios, and I am one that really needs the -n/--num-requests capability.

In short, a particular test (with plenty of sophistication in its design/operation) is needed for both typical load testing scenario, AND a separate scenario where a single execution must execute and exit as quickly as possible.

Can we restore the lost functionality ?

Yes, this would be a good feature to have. If we want to test performance for a particular number of requests rather than run-time.

heyman · 2019-10-17T12:47:18Z

Why was the -n/--num-requests removed ? Both mechanisms have distinct value/usage-scenarios, and I am one that really needs the -n/--num-requests capability.

One problem with having the --num-requests option is how it's supposed to work when running Locust distributed. Either we would make the master runner send out a stop message to all the worker nodes when the number of requests have been reached. However this method would result in a situation where more requests than the specified would be fired. This could be confusing for someone who assumes that the specified --num-requests would be respected. Alternatively the master node could - at start time - direct each node to only perform a certain number of requests, but that could cause some workers to stop generating load earlier than others, resulting in a RPS drop at the end of the test.

albertleadata · 2019-10-17T17:29:57Z

Why was the -n/--num-requests removed ? Both mechanisms have distinct value/usage-scenarios, and I am one that really needs the -n/--num-requests capability.

One problem with having the --num-requests option is how it's supposed to work when running Locust distributed.

It would be perfectly reasonable (and to me acceptable) if this were addressed by making the -n/--num-requests option supported for non-distributed operation only. It could even be asserted that it only makes sense in smaller-scale testing scenarios, which would naturally fall outside distributed operation anyway.

In my case, the need for it is specific to very small-scale tests that have to be executed at high iteration - the tests need to execute and completely exit as fast as possible, with only a specific and small number (often only 1) requests made.

heyman · 2019-10-18T08:55:04Z

It would be perfectly reasonable (and to me acceptable) if this were addressed by making the -n/--num-requests option supported for non-distributed operation only. It could even be asserted that it only makes sense in smaller-scale testing scenarios, which would naturally fall outside distributed operation anyway.

In my case, the need for it is specific to very small-scale tests that have to be executed at high iteration - the tests need to execute and completely exit as fast as possible, with only a specific and small number (often only 1) requests made.

I think everything that works non-distributed should work when running Locust distributed as well. We could possibly accept slightly different behaviour (e.g. the exact number of requests aren't guaranteed), but I'm not keen on having totally different feature sets.

Could you describe your use-case in more detail? To me, it doesn't really sound like it's a load test that you're doing.

albertleadata · 2019-10-18T17:51:52Z

Could you describe your use-case in more detail? To me, it doesn't really sound like it's a load test that you're doing.

Its not a load test - its what would be called a "synthetic health-check" ... its a test of arbitrary complexity that can benefit from (even require) all the functionality present in a load-testing tool like JMeter or Locust, but run to completion as quickly as possible with one iteration and 1 user.

vignesh-18 · 2020-02-06T14:53:49Z

Is there any way to stop the execution after specific number of requests are done?

TimorMuzi · 2020-06-11T05:42:03Z

Is there any way to stop the execution after specific number of requests are done?

Can you exit by throwing an StopLocus exception?
Or,You can try to judge in the code, when the number is reached, execute runners.locust_ runner.quit ()

heyman added 2 commits September 18, 2017 14:14

Added --run-time option that can be used, together with --no-web, to …

f5e3535

…specify how long a test should run

Removed --num-requests/-n option in favor of --run-time/-t

d4361cc

heyman mentioned this pull request Sep 18, 2017

Release new Locust version #657

Closed

aldenpeterson-wf reviewed Sep 18, 2017

View reviewed changes

heyman added 3 commits September 19, 2017 13:59

Merge branch 'master' into run-time-limit

4abc96f

Better exception message

44cf950

Documentation improvements:

34f3dd5

Moved info on how to run Locust without the web UI, and how to retrieve CSV stats, into their own documentation pages. Added info about --time-limit option. Added info about --expect-slaves option.

heyman merged commit cbd71e1 into master Sep 19, 2017

This was referenced Sep 19, 2017

Run the tests for the specified time #196

Closed

num-requests bug #512

Closed

aldenpeterson-wf mentioned this pull request Mar 30, 2018

Command line option to specify the duration to run #71

Closed

cgoldberg added this to the 0.9.0 milestone Apr 24, 2018

waberc reviewed Sep 27, 2018

View reviewed changes

mbeacom deleted the run-time-limit branch October 18, 2019 20:48

AngelosTheodosiadis mentioned this pull request Mar 26, 2020

[CICADA-29] Adding --run-time option when running headless datarobot/locust#6

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove --num-requests/-n in favor of --run-time/-t #656

Remove --num-requests/-n in favor of --run-time/-t #656

heyman commented Sep 18, 2017 •

edited

Loading

aldenpeterson-wf Sep 18, 2017

heyman Sep 19, 2017

aldenpeterson-wf commented Sep 18, 2017

heyman commented Sep 19, 2017

waberc Sep 27, 2018

diegotmorais Oct 15, 2018

eduardogmisiuk Oct 15, 2019

rk4n3 commented Aug 23, 2019

PraveenWhatfix commented Aug 23, 2019 •

edited

Loading

heyman commented Oct 17, 2019

albertleadata commented Oct 17, 2019

heyman commented Oct 18, 2019

albertleadata commented Oct 18, 2019

vignesh-18 commented Feb 6, 2020

TimorMuzi commented Jun 11, 2020

Remove --num-requests/-n in favor of --run-time/-t #656

Remove --num-requests/-n in favor of --run-time/-t #656

Conversation

heyman commented Sep 18, 2017 • edited Loading

aldenpeterson-wf Sep 18, 2017

Choose a reason for hiding this comment

heyman Sep 19, 2017

Choose a reason for hiding this comment

aldenpeterson-wf commented Sep 18, 2017

heyman commented Sep 19, 2017

waberc Sep 27, 2018

Choose a reason for hiding this comment

diegotmorais Oct 15, 2018

Choose a reason for hiding this comment

eduardogmisiuk Oct 15, 2019

Choose a reason for hiding this comment

rk4n3 commented Aug 23, 2019

PraveenWhatfix commented Aug 23, 2019 • edited Loading

heyman commented Oct 17, 2019

albertleadata commented Oct 17, 2019

heyman commented Oct 18, 2019

albertleadata commented Oct 18, 2019

vignesh-18 commented Feb 6, 2020

TimorMuzi commented Jun 11, 2020

heyman commented Sep 18, 2017 •

edited

Loading

PraveenWhatfix commented Aug 23, 2019 •

edited

Loading