Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task ratio #125

Merged
merged 4 commits into from
Feb 3, 2014
Merged

Fix task ratio #125

merged 4 commits into from
Feb 3, 2014

Conversation

sanga
Copy link
Contributor

@sanga sanga commented Jan 13, 2014

This would seem to fix: #123. Also simplified inspectlocust a bit which should make it easier to test. Also fixed a test in master that is currently broken on python 2.6

@sanga
Copy link
Contributor Author

sanga commented Jan 14, 2014

What do you think @Jahaja? Any chance to get this in or would you rather it reworked somehow?

@Jahaja
Copy link
Member

Jahaja commented Jan 14, 2014

Cool, looks good. I'll try to find time to test it tomorrow before merging it. Thanks for the PR!

@sanga
Copy link
Contributor Author

sanga commented Jan 14, 2014

Hmm, well I just spotted a grammar mistake in the doc updates, so at least
something to push a fix for tomorrow

On Tuesday, January 14, 2014, Joakim Hamrén wrote:

Cool, looks good. I'll try to find time to test it tomorrow before merging
it. Thanks for the PR!


Reply to this email directly or view it on GitHubhttps://github.com//pull/125#issuecomment-32297200
.

@sanga
Copy link
Contributor Author

sanga commented Jan 15, 2014

fixed grammar error (via force push, sorry)

@sanga
Copy link
Contributor Author

sanga commented Jan 22, 2014

Any action on this guys? I noticed that @heyman fixed the failing test so at least one commit could be dropped from here, but would it be otherwise mergable as is?

heyman added a commit that referenced this pull request Feb 3, 2014
@heyman heyman merged commit 8dbfbc7 into locustio:master Feb 3, 2014
@heyman
Copy link
Member

heyman commented Feb 3, 2014

Hey! Thanks for the fix! Sorry it has taken so long to get this merged.

@sanga
Copy link
Contributor Author

sanga commented Feb 3, 2014

no probs. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locust.weight supported, just undocumented?
3 participants