Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update build_url function in Locust HttpSession " #1148

Merged

Conversation

vstepanov-lohika-tix
Copy link
Contributor

@vstepanov-lohika-tix vstepanov-lohika-tix commented Nov 15, 2019

Reverts #1134
Unfortunately, I've found a big disadvantage of this change:
urljoin from urllib has a surprising behavior: it cuts everything in base url after "/", if the second part of url to join starts from "/".
For example, urljoin("http://mysite.com/api/v0", "/path/to/join")" returns a result: http://mysite.com/path/to/join`

It will lead to a lot of issues and errors in all existing locust tests where combined base url is used.
The only option I see is to revert this change. Sorry for inconvenience.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          20       20           
  Lines        1881     1881           
  Branches      290      290           
=======================================
  Hits         1422     1422           
  Misses        392      392           
  Partials       67       67
Impacted Files Coverage Δ
locust/clients.py 91.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7146515...a9134fb. Read the comment docs.

@heyman
Copy link
Member

heyman commented Nov 15, 2019

Ah, that's unfortunate. Good that you catched it!

@heyman heyman merged commit 1f3fa12 into locustio:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants