Revert "update build_url function in Locust HttpSession " #1148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1134
Unfortunately, I've found a big disadvantage of this change:
urljoin
fromurllib
has a surprising behavior: it cuts everything in base url after "/", if the second part of url to join starts from "/".For example,
urljoin("http://mysite.com/api/v0", "/path/to/join")" returns a result:
http://mysite.com/path/to/join`It will lead to a lot of issues and errors in all existing locust tests where combined base url is used.
The only option I see is to revert this change. Sorry for inconvenience.