Escape HTML entities in endpoint names #374 #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL names (for stats) were not HTML-escaped in the dashboard. This made names with angle brackets disappear. For example: ``` self.client.get(url, name='/some-resource/upload/<uuid>') ``` would show up as `/some-resource/upload/` instead of `/some-resource/upload/<uuid>` which is confusing. I added new key to /stats/request - "safe_name" - so that escaping is on the server side and javascript has less logic.
|
Awesome! Looks like it has issues in Python 2.7 though... "ImportError: No module named html" |
Actually cgi.escape is still available in Python3.7, but is deprecated. So going forward, it's safer to import escape from html. I disabled escaping quotes (quote=False) for consistency and because it's not needed for this purpose.
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 72.69% 72.75% +0.06%
==========================================
Files 18 18
Lines 1765 1769 +4
Branches 262 262
==========================================
+ Hits 1283 1287 +4
Misses 420 420
Partials 62 62
Continue to review full report at Codecov.
|
|
Ah, I forgot to check if Python 2.7 is still supported. BTW, what are the plans on dropping Python 2.7 support? |
|
Hopefully soon, IMHO :) thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL names (for stats) were not HTML-escaped in the dashboard.
This made names with angle brackets disappear. For example:
would show up as
/some-resource/upload/instead of/some-resource/upload/<uuid>which is confusing.I added new key to /stats/request - "safe_name" - so that escaping
is on the server side and javascript has less logic.