Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Add docs for self-managed Kafka cluster #130

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

HarshCasper
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-130.surge.sh 🎊

@HarshCasper HarshCasper requested a review from thrau March 22, 2022 14:33
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks great 💯 ! would be great if we could use the command shortcode, other than that: good to merge!

Comment on lines 18 to 20
```sh
$ docker-compose up -d
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great if we could use the {{< command >}} shortcode for the commands, see #55 for details.

Comment on lines 24 to 31
```sh
$ awslocal lambda create-function \
--function-name fun1 \
--handler lambda.handler \
--runtime python3.8 \
--role r1 \
--zip-file fileb://lambda.zip
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-line commands are also supported by #55 :-)

@HarshCasper HarshCasper merged commit a41ee9e into main Mar 22, 2022
@HarshCasper HarshCasper deleted the self-managed-kafka-cluster branch March 22, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants