Skip to content

Commit

Permalink
chore(cloudformation): rename prefix for change set name (aws#1305)
Browse files Browse the repository at this point in the history
related aws#362

Current prefix for ChangeSetName is "ecscli-". ECS CLI v2 was former name, so I think "copilot-" is better.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
  • Loading branch information
tam0ri authored and thrau committed Dec 9, 2022
1 parent 2efbec6 commit a7fdd23
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/pkg/aws/cloudformation/changeset.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
const (
// The change set name must match the regex [a-zA-Z][-a-zA-Z0-9]*. The generated UUID can start with a number,
// by prefixing the uuid with a word we guarantee that we start with a letter.
fmtChangeSetName = "ecscli-%s"
fmtChangeSetName = "copilot-%s"

// Status reasons that can occur if the change set execution status is "FAILED".
noChangesReason = "NO_CHANGES_REASON"
Expand Down
2 changes: 1 addition & 1 deletion internal/pkg/aws/cloudformation/cloudformation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"github.com/stretchr/testify/require"
)

const mockChangeSetName = "ecscli-31323334-3536-4738-b930-313233333435"
const mockChangeSetName = "copilot-31323334-3536-4738-b930-313233333435"

var (
mockStack = NewStack("id", "template")
Expand Down

0 comments on commit a7fdd23

Please sign in to comment.