🐛 fix: fix inbox agent can not save config #6186

arvinxx · 2025-02-15T16:31:50Z

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

之前的实现中，由于创建 inbox 的逻辑中包含有服务端 env 的环境变量，因此会导致 session 无法正常创建，进而导致 inbox 助手配置丢失。

本 PR 将和服务端 env 耦合部分抽离开来，各自在对应环节做初始化。进而修正

vercel · 2025-02-15T16:31:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lobe-chat-database	✅ Ready (Inspect)	Visit Preview		Feb 16, 2025 0:23am
lobe-chat-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 16, 2025 0:23am

gru-agent · 2025-02-15T16:39:53Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`9795a6b`	✅ Finished	Cancelled by auto rebase

Files

File	Pull Request
src/database/server/models/session.ts	🛑 Cancelled (Cancelled by auto rebase)
src/database/server/models/user.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/routers/lambda/agent.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/agent/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/user/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/services/session/client.ts	🛑 Cancelled (Cancelled by auto rebase)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

codecov · 2025-02-15T16:42:20Z

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (6398362) to head (d52db7d).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/services/session/client.ts	16.66%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6186      +/-   ##
==========================================
- Coverage   91.81%   91.80%   -0.02%     
==========================================
  Files         667      668       +1     
  Lines       61110    61144      +34     
  Branches     4453     4457       +4     
==========================================
+ Hits        56110    56134      +24     
- Misses       5000     5010      +10

Flag	Coverage Δ
app	`91.80% <77.77%> (-0.02%)`	⬇️
server	`97.90% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gru-agent · 2025-02-15T16:59:25Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`525cf07`	✅ Finished

Files

File	Pull Request
src/database/server/models/session.ts	🛑 Cancelled (Cancelled by auto rebase)
src/database/server/models/user.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/routers/lambda/agent.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/agent/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/user/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/services/session/client.ts	🛑 Cancelled (Cancelled by auto rebase)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

gru-agent · 2025-02-15T17:09:53Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`e617619`	✅ Finished	Cancelled by auto rebase

Files

File	Pull Request
src/database/server/models/session.ts	🛑 Cancelled (Cancelled by auto rebase)
src/database/server/models/user.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/routers/lambda/agent.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/agent/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/server/services/user/index.ts	🛑 Cancelled (Cancelled by auto rebase)
src/services/session/client.ts	🛑 Cancelled (Cancelled by auto rebase)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

gru-agent · 2025-02-15T17:13:25Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`21cb7c9`	✅ Finished

Files

File	Pull Request
src/database/server/models/session.ts	❌ Failure (I failed to write the unit tests for the file.)
src/database/server/models/user.ts	❌ Failure (I failed to setup the environment.)
src/server/routers/lambda/agent.ts	🔴 Closed #6192
src/server/services/agent/index.ts	❌ Failure (I failed to setup the environment.)
src/server/services/user/index.ts	❌ Failure (I failed to setup the environment.)
src/services/session/client.ts	❌ Failure (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

…os. (#6188) Co-authored-by: gru-agent[bot] <185149714+gru-agent[bot]@users.noreply.github.com>

#6187) Co-authored-by: gru-agent[bot] <185149714+gru-agent[bot]@users.noreply.github.com>

### [Version 1.56.2](v1.56.1...v1.56.2) <sup>Released on **2025-02-16**</sup> #### 🐛 Bug Fixes - **misc**: Fix inbox agent can not save config. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix inbox agent can not save config, closes [#6186](#6186) ([588cba7](588cba7)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

## [Version 1.98.0](v1.97.1...v1.98.0) <sup>Released on **2025-02-16**</sup> #### ✨ Features - **misc**: Add configurable PDF processing method with Unstructured. #### 🐛 Bug Fixes - **misc**: Fix inbox agent can not save config, fix inbox agent edit way in the new mode. #### 💄 Styles - **misc**: Improve mobile params style. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add configurable PDF processing method with Unstructured, closes [lobehub#5927](https://github.com/bentwnghk/lobe-chat/issues/5927) ([35fa3ee](35fa3ee)) #### What's fixed * **misc**: Fix inbox agent can not save config, closes [lobehub#6186](https://github.com/bentwnghk/lobe-chat/issues/6186) ([588cba7](588cba7)) * **misc**: Fix inbox agent edit way in the new mode, closes [lobehub#6190](https://github.com/bentwnghk/lobe-chat/issues/6190) ([6398362](6398362)) #### Styles * **misc**: Improve mobile params style, closes [lobehub#6176](https://github.com/bentwnghk/lobe-chat/issues/6176) ([b5276de](b5276de)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

### [Version 1.56.2](lobehub/lobe-chat@v1.56.1...v1.56.2) <sup>Released on **2025-02-16**</sup> #### 🐛 Bug Fixes - **misc**: Fix inbox agent can not save config. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix inbox agent can not save config, closes [lobehub#6186](lobehub#6186) ([588cba7](lobehub@588cba7)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 15, 2025

dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Feb 15, 2025

vercel bot deployed to Preview – lobe-chat-preview February 15, 2025 16:51 View deployment

gru-agent bot mentioned this pull request Feb 15, 2025

✅ test: add unit test for src/server/services/user/index.ts #6187

Merged

vercel bot deployed to Preview – lobe-chat-database February 15, 2025 16:57 View deployment

gru-agent bot mentioned this pull request Feb 15, 2025

✅ test: add unit test for src/server/services/agent/index.ts #6188

Merged

arvinxx force-pushed the fix/assisant branch from 21cb7c9 to d3f4bf0 Compare February 15, 2025 17:19

arvinxx changed the title ~~🐛 fix: fix inbox agent can not save config~~ 🐛 fix: fix inbox agent can not save config and edit Feb 15, 2025

vercel bot deployed to Preview – lobe-chat-preview February 15, 2025 17:30 View deployment

vercel bot deployed to Preview – lobe-chat-database February 15, 2025 17:31 View deployment

gru-agent bot mentioned this pull request Feb 15, 2025

✅ test: add unit test for src/server/routers/lambda/agent.ts #6192

Closed

arvinxx and others added 6 commits February 16, 2025 07:57

fix inbox agent config

5a20503

fix tests

c624498

fix tests

fbdbb63

fix tests

edb3bdf

Add unit tests for AgentService, including createInbox method scenari…

2caace3

…os. (#6188) Co-authored-by: gru-agent[bot] <185149714+gru-agent[bot]@users.noreply.github.com>

Add AgentService mock and verify its interaction in UserService tests. (

d52db7d

#6187) Co-authored-by: gru-agent[bot] <185149714+gru-agent[bot]@users.noreply.github.com>

arvinxx force-pushed the fix/assisant branch from d3f4bf0 to d52db7d Compare February 15, 2025 23:57

arvinxx changed the title ~~🐛 fix: fix inbox agent can not save config and edit~~ 🐛 fix: fix inbox agent can not save config Feb 16, 2025

vercel bot deployed to Preview – lobe-chat-preview February 16, 2025 00:18 View deployment

vercel bot deployed to Preview – lobe-chat-database February 16, 2025 00:23 View deployment

arvinxx merged commit 588cba7 into main Feb 16, 2025
14 of 15 checks passed

arvinxx deleted the fix/assisant branch February 16, 2025 00:29

ramu-narasinga pushed a commit to ramu-narasinga/lobe-chat that referenced this pull request Feb 17, 2025

🐛 fix: fix inbox agent can not save config (lobehub#6186)

2b198b4

bentwnghk pushed a commit to bentwnghk/lobe-chat that referenced this pull request Feb 20, 2025

🐛 fix: fix inbox agent can not save config (lobehub#6186)

f4bce0f

likaiqiang pushed a commit to likaiqiang/lobe-chat that referenced this pull request Feb 26, 2025

🐛 fix: fix inbox agent can not save config (lobehub#6186)

94dc426

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 fix: fix inbox agent can not save config #6186

🐛 fix: fix inbox agent can not save config #6186

arvinxx commented Feb 15, 2025 •

edited

Loading

vercel bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

codecov bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

🐛 fix: fix inbox agent can not save config #6186

🐛 fix: fix inbox agent can not save config #6186

Conversation

arvinxx commented Feb 15, 2025 • edited Loading

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel bot commented Feb 15, 2025 • edited Loading

gru-agent bot commented Feb 15, 2025 • edited Loading

TestGru Assignment

Summary

Files

codecov bot commented Feb 15, 2025 • edited Loading

Codecov Report

gru-agent bot commented Feb 15, 2025 • edited Loading

TestGru Assignment

Summary

Files

gru-agent bot commented Feb 15, 2025 • edited Loading

TestGru Assignment

Summary

Files

gru-agent bot commented Feb 15, 2025 • edited Loading

TestGru Assignment

Summary

Files

arvinxx commented Feb 15, 2025 •

edited

Loading

vercel bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

codecov bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading

gru-agent bot commented Feb 15, 2025 •

edited

Loading