Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(service): Seperate data import and export services #3241

Closed

Conversation

CloudPassenger
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

Refactor data import and export services to complete a TODO task

  • TODO: Separate export functionality into a new service similar to importService

📝 补充信息 | Additional Information

A prompt screen will be implemented later to prompt the user to upload data from the IndexedDB to the server after the server-side database has been set up to optimise the user experience (no need to backup restore data beforehand).

Copy link

vercel bot commented Jul 17, 2024

@CloudPassenger is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @CloudPassenger

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 30.12821% with 109 lines in your changes missing coverage. Please review.

Project coverage is 91.81%. Comparing base (18a240c) to head (fb6a014).
Report is 1164 commits behind head on main.

Files with missing lines Patch % Lines
src/services/export/server.ts 10.90% 98 Missing ⚠️
src/services/export/client.ts 64.28% 5 Missing ⚠️
src/services/export/index.ts 69.23% 4 Missing ⚠️
src/services/export/utils.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3241      +/-   ##
==========================================
- Coverage   92.45%   91.81%   -0.65%     
==========================================
  Files         482      489       +7     
  Lines       34363    34789     +426     
  Branches     2125     2128       +3     
==========================================
+ Hits        31772    31940     +168     
- Misses       2591     2849     +258     
Flag Coverage Δ
app 91.81% <30.12%> (-0.65%) ⬇️
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4,3 +4,5 @@ import { getServerDBConfig } from '@/config/db';
export const CURRENT_VERSION = pkg.version;

export const isServerMode = getServerDBConfig().NEXT_PUBLIC_ENABLED_SERVER_SERVICE;

// 检查是否存在配置遗留
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need?

@arvinxx
Copy link
Contributor

arvinxx commented Jul 22, 2024

please keep the coverage of src/services/export/server.ts

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a rebase now

@CloudPassenger CloudPassenger force-pushed the refactor/export-service branch from 881ad71 to bd9388e Compare August 6, 2024 22:40
@arvinxx
Copy link
Contributor

arvinxx commented Sep 10, 2024

@CloudPassenger rebase 下?

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 24, 2024
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 0:40am

@arvinxx
Copy link
Contributor

arvinxx commented Feb 13, 2025

export 这部分要结合 #5581 重写了,这个PR我先关了~

@arvinxx arvinxx closed this Feb 13, 2025
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Export This part needs to be rewritten in combination with #5581, I will close this PR first~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants