Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMB-712: add source_material property #501

Merged
merged 1 commit into from
Jul 16, 2024
Merged

CMB-712: add source_material property #501

merged 1 commit into from
Jul 16, 2024

Conversation

sachinmurali
Copy link
Contributor

@sachinmurali sachinmurali commented Jul 15, 2024

Fixes CMB-712

Checklist

  • Up to date with main
  • All the tests are passing
    • Delete all resources created in tests
  • Prettier
  • Spectral Lint
  • npm run bundle outputs nothing suspect
  • npm run postman outputs nothing suspect

Changes

Adds the source_material property to booklets.

Areas of Concern (optional)

@sachinmurali sachinmurali requested a review from a team as a code owner July 15, 2024 22:13
@sachinmurali sachinmurali requested a review from a team July 15, 2024 22:13
Comment on lines +6 to +9
description: >-
Defines the material used to create the mail piece, specifically for booklets.
This property is directly tied to the size of the booklet, ensuring that the appropriate material is selected based on the booklet's dimensions.
For booklets with `size` equal to `8.375x5.375` inches, the default source material is `60# Gloss Text`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachinmurali
Copy link
Contributor Author

Screenshot 2024-07-15 at 3 16 32 PM
Screenshot 2024-07-15 at 3 17 00 PM

Copy link

@samkitsheth95 samkitsheth95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sachinmurali sachinmurali merged commit e07451f into main Jul 16, 2024
6 checks passed
@sachinmurali sachinmurali deleted the CMB-712 branch July 16, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants