Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement no-async-describe rule #188

Merged
merged 5 commits into from
Feb 13, 2019
Merged

Implement no-async-describe rule #188

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e509877
Implement no-async-describe rule
papandreou Feb 5, 2019
d1ffa55
Fix wrong string-less describe in test cases
papandreou Feb 13, 2019
7c9b6dc
Review fixes
papandreou Feb 13, 2019
a5fa46a
Fix error message
papandreou Feb 13, 2019
0c113b5
Simplify the fixer
papandreou Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify the fixer 
#188 (comment)
  • Loading branch information
@papandreou
papandreou committed Feb 13, 2019
commit 0c113b53b6a7f82efbd3729b04a7f3c59fbb8f3e
7 changes: 3 additions & 4 deletions lib/rules/no-async-describe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,9 @@ module.exports = function (context) {

function fixAsyncFunction(fixer, fn) {
if (!containsDirectAwait(fn.body)) {
return fixer.replaceTextRange(
[ fn.start, fn.end ],
sourceCode.text.slice(fn.range[0], fn.range[1]).replace(/^async /, '')
);
// Remove the "async" token and all the whitespace before "function":
const [ asyncToken, functionToken ] = sourceCode.getFirstTokens(fn, 2);
return fixer.removeRange([ asyncToken.range[0], functionToken.range[0] ]);
}
return undefined;
}
Expand Down