Fix CI by run Typescript compiler using npx #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run typescript using `npx tsc` command as that will use typescript version specified in package.json file. This ensures that breaking changes in TS compiler will not break the build.
webwarrior-ws
changed the title
Use `npx tsc` instead of `tsc` in "scripts" section of `package.json` so that Typescript version specified in the file is used.
grunch
approved these changes
Mar 19, 2024
|
Hi @webwarrior-ws I'm getting a CI failing test after this PR was merged, any ideas how to fix it?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run typescript using
npx tsccommand as that will use typescript version specified in package.json file. This ensures that breaking changes in TS compiler will not break the build.Also use
npx tscinstead oftscin "scripts" section ofpackage.json.