-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up __init__.py -- especially remove __version__
#257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 96.33% 96.37% +0.04%
==========================================
Files 15 15
Lines 1909 1906 -3
==========================================
- Hits 1839 1837 -2
+ Misses 70 69 -1 ☔ View full report in Codecov by Sentry. |
-1 from me on removing |
__version__
@newville More details on why -1 on removing If downstream projects (is lmfit included here?) need the version number dynamically the modern practice is |
@jagerber48 -1 on the concept of "modern practice" when it comes to any of the relentless churn that is Python packaging.
For me, this:
gives:
An equal number of projects fail with both. FWIW, you would need to do And indeed,
has no obvious analog. Because The continual churn that is Python packaging is changing problems, but not solving them. Again, -1 on dropping |
Ok thanks for that additional detail. We can support both for now. I’ll close this shortly. There is other cleanup than can happen but at a later time. I was inspired to make this PR in thinking about the rtd issue but that’s handled in #255 |
@newville what of |
Nevermind, see #258 |
Closes # (insert issue number)
Executed
pre-commit run --all-files
with no errorsThe change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file
Remove
__author__
. This is captured inpyproject.toml
.Remove long docstring. Hopefully this docstring is essentially captured in
README.rst
Remove legacy "version" stuff. The modern strategy for users to get
uncertainties
version information at runtime is to dofrom importlib.metadata import version
and runversion('uncertainties')
.The version import is breaking the read the docs build right now, so this will hopefully resolve that issue.