Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: make sure spercent is defined #770

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

reneeotten
Copy link
Contributor

Description

This fixes the issue reported in #768 regarding the undefined spercent variable.

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.9.9 (main, Nov 16 2021, 07:21:43)
[Clang 11.0.3 (clang-1103.0.32.62)]

lmfit: 1.0.3.post6+g1b9a88f, scipy: 1.7.3, numpy: 1.21.4, asteval: 0.9.25, uncertainties: 3.1.6

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #770 (47602d3) into master (1b9a88f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          10       10           
  Lines        3410     3411    +1     
=======================================
+ Hits         3197     3198    +1     
  Misses        213      213           
Impacted Files Coverage Δ
lmfit/printfuncs.py 99.58% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9a88f...47602d3. Read the comment docs.

@newville
Copy link
Member

@reneeotten Thanks! I say we merge, but I guess we should wait until the tests pass.

@newville
Copy link
Member

newville commented Dec 1, 2021

merging!

@newville newville merged commit 275d830 into lmfit:master Dec 1, 2021
@reneeotten reneeotten deleted the fix-spercent-html branch December 1, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants